Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_packager: rename no_heap_copy to heap_copy for clarity #9700

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@Beuc
Copy link
Contributor

Beuc commented Oct 24, 2019

When 'no_heap_copy' is set there is a heap copy and vice-versa -- let's clarify.
This is also more consistent with emcc.py.

When 'no_heap_copy' there is a heap copy and vice-versa -- let's clarify.
This is also more consistent with emcc.py.
@sbc100
sbc100 approved these changes Oct 24, 2019
@kripken

This comment has been minimized.

Copy link
Member

kripken commented Oct 25, 2019

Thanks!

I think this is good as it's closer to emcc.py. But there are two possible copies, one initially during filesystem load, and later copies during fread operations. I'll edit the commit message slightly for that.

@kripken kripken merged commit 7e2bbb2 into emscripten-core:incoming Oct 25, 2019
28 of 30 checks passed
28 of 30 checks passed
ci/circleci: test-browser-firefox Your tests failed on CircleCI
Details
ci/circleci: test-upstream-browser-firefox Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-upstream-linux Your tests passed on CircleCI!
Details
ci/circleci: build-upstream-mac Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: test-ab Your tests passed on CircleCI!
Details
ci/circleci: test-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-c Your tests passed on CircleCI!
Details
ci/circleci: test-d Your tests passed on CircleCI!
Details
ci/circleci: test-e Your tests passed on CircleCI!
Details
ci/circleci: test-f Your tests passed on CircleCI!
Details
ci/circleci: test-ghi Your tests passed on CircleCI!
Details
ci/circleci: test-jklmno Your tests passed on CircleCI!
Details
ci/circleci: test-other Your tests passed on CircleCI!
Details
ci/circleci: test-p Your tests passed on CircleCI!
Details
ci/circleci: test-qrst Your tests passed on CircleCI!
Details
ci/circleci: test-sanity Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other-mac Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm0 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm2 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm2js1 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm3 Your tests passed on CircleCI!
Details
ci/circleci: test-uvwxyz Your tests passed on CircleCI!
Details
ci/circleci: test-wasm0 Your tests passed on CircleCI!
Details
ci/circleci: test-wasm2 Your tests passed on CircleCI!
Details
ci/circleci: test-wasm3 Your tests passed on CircleCI!
Details
@Beuc

This comment has been minimized.

Copy link
Contributor Author

Beuc commented Oct 25, 2019

@kripken do you mean "later copies during mmap operations"?
(I did not find where fread would trigger an additional copy depending on whether the file is backed by xhr.response or HEAP8.)

@kripken

This comment has been minimized.

Copy link
Member

kripken commented Oct 25, 2019

Ah, right, I guess mmap is where the later copy could happen.

@Beuc Beuc deleted the Beuc:patch-8 branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.