Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: asyncify updates #9707

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@Beuc
Copy link
Contributor

Beuc commented Oct 25, 2019

document asyncify along with emterpreter
regroup emscripten_wget_data with emscripten_wget
report notes from https://emscripten.org/docs/porting/asyncify.html wrt emterpreter_sleep/emterpreter_sleep_with_yield

@kripken

This comment has been minimized.

Copy link
Member

kripken commented Oct 28, 2019

Thanks @Beuc! Good idea. Looks like something landed meanwhile though that needs to be merged into here first.

@Beuc Beuc force-pushed the Beuc:patch-9 branch from 0819050 to 45253b5 Oct 28, 2019
@Beuc

This comment has been minimized.

Copy link
Contributor Author

Beuc commented Oct 28, 2019

Apparently you did a similar change a few hours after this PR.
This was a damn nightmare to merge.
But hopefully things are a bit clear now.

I incidentally introduced "pseudo-synchronous" to avoid describing both wget and wget_async as "asynchronous".
Also replaced "Emscripten Asynchronous xxx" with "Asynchronous xxx" since I keep seeing "Emterpreter Asynchronous" and this is another headache material ;)

@Beuc Beuc force-pushed the Beuc:patch-9 branch from 45253b5 to 17a6d68 Oct 28, 2019
@Beuc Beuc force-pushed the Beuc:patch-9 branch from 17a6d68 to 0afacb8 Oct 28, 2019
Copy link
Member

kripken left a comment

Thanks! And sorry for that merge, yeah, unlucky timing...

@kripken kripken merged commit 6f4a0ae into emscripten-core:incoming Oct 29, 2019
30 checks passed
30 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-upstream-linux Your tests passed on CircleCI!
Details
ci/circleci: build-upstream-mac Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: test-ab Your tests passed on CircleCI!
Details
ci/circleci: test-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-browser-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-c Your tests passed on CircleCI!
Details
ci/circleci: test-d Your tests passed on CircleCI!
Details
ci/circleci: test-e Your tests passed on CircleCI!
Details
ci/circleci: test-f Your tests passed on CircleCI!
Details
ci/circleci: test-ghi Your tests passed on CircleCI!
Details
ci/circleci: test-jklmno Your tests passed on CircleCI!
Details
ci/circleci: test-other Your tests passed on CircleCI!
Details
ci/circleci: test-p Your tests passed on CircleCI!
Details
ci/circleci: test-qrst Your tests passed on CircleCI!
Details
ci/circleci: test-sanity Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-browser-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other-mac Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm0 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm2 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm2js1 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm3 Your tests passed on CircleCI!
Details
ci/circleci: test-uvwxyz Your tests passed on CircleCI!
Details
ci/circleci: test-wasm0 Your tests passed on CircleCI!
Details
ci/circleci: test-wasm2 Your tests passed on CircleCI!
Details
ci/circleci: test-wasm3 Your tests passed on CircleCI!
Details
@Beuc Beuc deleted the Beuc:patch-9 branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.