Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch default backend from 'fastcomp' to 'upstream' #373
Conversation
This comment has been minimized.
This comment has been minimized.
|
Before we land this we should have docs probably, but I'm not sure where? |
This comment has been minimized.
This comment has been minimized.
|
Actually, maybe we could have the emsdk say something? Like show a message, "the default backend has changed" on first run after the change? |
This comment has been minimized.
This comment has been minimized.
|
Good idea. Added a bit notice. |
This comment has been minimized.
This comment has been minimized.
|
Looks good, thanks! |
This comment has been minimized.
This comment has been minimized.
|
In offline discussion we had the idea to maybe not always default to upstream, but just from 1.39.0 and onwards. The idea being that say at a version from last year, upstream's support was not that great yet, so it would be bad. Only at 1.39.0 are we confident the new backend is good enough for general use. Let's discuss more and decide next week. |
This comment has been minimized.
This comment has been minimized.
|
Updated so that we now only default for upstream for 'latest' and for 1.39.0 and above. |
When users as for 'latest' or just '1.39.0' we now default to the upstream llvm backend. For versions before 1.39.0 we continue to default to fastcomp. Fixes: emscripten-core/emscripten#5488
| if arg in ('latest', 'sdk-latest', 'latest-64bit', 'sdk-latest-64bit', 'latest-fastcomp', 'latest-releases-fastcomp'): | ||
| if arg in ('latest', 'sdk-latest', 'latest-64bit', 'sdk-latest-64bit'): | ||
| # This is effectly the default SDK | ||
| report_upstream_by_default() |
This comment has been minimized.
This comment has been minimized.
kripken
Oct 21, 2019
Member
I think we can report this only if the version is high enough? Can maybe share code with the existing check later down.
This comment has been minimized.
This comment has been minimized.
sbc100
Oct 21, 2019
Author
Contributor
The version check make sense below, but here we know that we want to unconditionally select upstream right? We never want latest to point to fastcomp ever again, do we? And if we do we would revert this code.
This comment has been minimized.
This comment has been minimized.
|
|
sbc100 commentedOct 16, 2019
•
edited
When users as for 'latest' or just '1.39.0' we now default to the upstream llvm backend.
For versions before 1.39.0 we continue to default to fastcomp.
Fixes: emscripten-core/emscripten#5488