Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.19 #811

Merged
merged 1 commit into from May 4, 2021
Merged

2.0.19 #811

merged 1 commit into from May 4, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 4, 2021

No description provided.

@sbc100 sbc100 requested review from dschuff and kripken May 4, 2021 15:01
kripken
kripken previously approved these changes May 4, 2021
@sbc100 sbc100 force-pushed the version_2_0_19 branch 2 times, most recently from 7f61b9b to a9af1fb Compare May 4, 2021 21:51
@kripken
Copy link
Member

kripken commented May 4, 2021

Aside from the test failures this lgtm to land. (Even before the LTO one finishes all tests - we can remove it later if we want.)

@kripken
Copy link
Member

kripken commented May 4, 2021

Actually, are the lto and non-lto versions identical in the DEPS they are built from?

@sbc100
Copy link
Collaborator Author

sbc100 commented May 4, 2021

Actually, are the lto and non-lto versions identical in the DEPS they are built from?

Yup that is my understanding

@kripken
Copy link
Member

kripken commented May 4, 2021

Yes, I verified they are identical now, sorry. I was misreading it before.

@sbc100 sbc100 enabled auto-merge (squash) May 4, 2021 22:07
@sbc100 sbc100 disabled auto-merge May 4, 2021 22:24
@sbc100 sbc100 merged commit 33ce2bd into main May 4, 2021
@sbc100 sbc100 deleted the version_2_0_19 branch May 4, 2021 22:25
radekdoulik pushed a commit to dotnet/emsdk that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants