Skip to content

Conversation

@DerThorsten
Copy link
Collaborator

No description provided.

@martinRenou
Copy link
Contributor

Should we port those changes to mambajs's copy of dynload ?

@DerThorsten
Copy link
Collaborator Author

DerThorsten commented Mar 26, 2025

@martinRenou I think we have to. But its not a good situation that we have to maintain two implementations

@DerThorsten
Copy link
Collaborator Author

ignoring the doc workflow build errors atm

@DerThorsten DerThorsten merged commit 30efd05 into emscripten-forge:main Mar 26, 2025
1 of 2 checks passed
@martinRenou
Copy link
Contributor

Agreed it's not a good solution. I'm thinking we should rename mambajs but not sure of a good name yet, what it really is is a package to handle conda packages in the front-end and load them (including load shared libs). How about we rely on mambajs in pyjs?

@DerThorsten
Copy link
Collaborator Author

Agreed it's not a good solution. I'm thinking we should rename mambajs but not sure of a good name yet, what it really is is a package to handle conda packages in the front-end and load them (including load shared libs). How about we rely on mambajs in pyjs?

jeah we should to that. It will just be a bit complicated to integrate it in the build system properly.
So far its pure cmake

@martinRenou
Copy link
Contributor

Something like esbuild could help, without going through the webpack nonsense, with a small script we could build a JS bundle and include it in pre-js.

@DerThorsten
Copy link
Collaborator Author

Something like esbuild could help, without going through the webpack nonsense, with a small script we could build a JS bundle and include it in pre-js.

that would be perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants