New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CloseAudio actually close audio #63

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@Beuc
Contributor

Beuc commented Nov 15, 2018

Currently CloseAudio is a no-op. Consequently the audio callback keeps being called even after exiting the program, causing an endless stream of errors in the console.

This one-line patch fixes the issue.

Note: this was reported at https://bugzilla.libsdl.org/show_bug.cgi?id=4176
but upstream does not seem reactive. Any way to push it for inclusion there?

@Daft-Freak

This comment has been minimized.

Member

Daft-Freak commented Nov 15, 2018

Looks simple enough. If you prefix the commit message with "Emscripten: " I should be able to push it upstream.

@Beuc

This comment has been minimized.

Contributor

Beuc commented Nov 15, 2018

All set :)

@Daft-Freak Daft-Freak merged commit 1e9a88e into emscripten-ports:master Nov 15, 2018

@Daft-Freak

This comment has been minimized.

Member

Daft-Freak commented Nov 15, 2018

@Beuc Beuc deleted the Beuc:patch-1 branch Nov 15, 2018

@Beuc

This comment has been minimized.

Contributor

Beuc commented Nov 15, 2018

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment