Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WAxisSliderWidget and chart viewport fail to sync #186

Closed
wants to merge 2 commits into from
Closed

Fix WAxisSliderWidget and chart viewport fail to sync #186

wants to merge 2 commits into from

Conversation

Apivan
Copy link
Contributor

@Apivan Apivan commented Feb 4, 2022

No description provided.

@Apivan
Copy link
Contributor Author

Apivan commented Feb 4, 2022

Fix issue https://redmine.webtoolkit.eu/issues/9719

RockinRoel
RockinRoel suggested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@RockinRoel RockinRoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution. How did you minify the source code? I think it's likely not the same minifier as we're using. I'll do the minification myself (eventually we want to switch all of Wt's JavaScript over to another minifier).

Regards,
Roel

@Apivan
Copy link
Contributor Author

Apivan commented Jun 27, 2022

I used babel node js to minify.

@emweb
Copy link
Collaborator

emweb commented Jun 27, 2022

Yeah, we're using an old version of Google Closure compiler at the moment. I minified it and made another small fix (o.wtSObj instead of o[0].wtSObj) and did a manual merge, so this can be closed now.

Regards,
Roel

@emweb emweb closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RockinRoel RockinRoel RockinRoel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Apivan @emweb @RockinRoel @apivan2