Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a possible access violation in WebSession #193

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

skoehler47
Copy link
Contributor

This pull request contains a fix for a segmentation fault during application creation, if the application create function used for an entry point returns a nullptr - as described in Issue 10483.

@skoehler47 skoehler47 changed the title Fixed an access violation that crashes the whole server whenever Fixed a possible access violation in WebSession Jun 12, 2022
Copy link
Collaborator

@emweb emweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have a few small remarks. If you can address them that would be great 🙂

Roel

src/web/WebSession.C Outdated Show resolved Hide resolved
src/web/WebSession.C Outdated Show resolved Hide resolved
the 'ApplicationCreator function' returns a nullptr
@emweb emweb merged commit 8a4c465 into emweb:master Jun 23, 2022
@skoehler47 skoehler47 deleted the fix-wt-02 branch October 4, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants