Fix WTreeView loading. See #11240#199
Closed
jhnstrk wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks. Having it return I manually merged this with some changes (adding your description to the commit message and adding release notes), so I'm closing this PR. Roel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rows are removed,
WTreeView::modelRowsAboutToBeRemovedcallsisExpandedRecursiveto determine if rendered tree nodes are impacted by the removal. However,isExpandedRecursivewas always returning false for the root node. This seems odd, when the root node is always expanded. This behaviour caused a bug because theremovedHeight_was not being set. This lead to thechildrenHeightnot being updated, and the loading isn't triggered.Switching
isExpandedRecursiveto true for the root index fixes the issue ... but maybe it was intentionally set like this, but I can't see why.