emyl3
Follow
Pinned
403 contributions in the last year
We're celebrating 100 million developers!
Contribution activity
January 2023
Created 5 commits in 2 repositories
Created a pull request in CDCgov/prime-simplereport-site that received 9 comments
Upgrade ruby to version 3.1
Related Issue or Background Info Resolves #4859 Changes Proposed Upgrade to ruby 3.1 Additional Information As stated in a comment in the issue, M…
+21
−18
•
9
comments
Opened 4 other pull requests in 1 repository
CDCgov/prime-simplereport
4
merged
Reviewed 29 pull requests in 2 repositories
CDCgov/prime-simplereport
25 pull requests
- Spec 06 failing: Adds wait check before asserting for manage organizations title
- drop testPerformedCode from join table
- publish fhir events to queue
- Added custom metric for patient upload
- rollback without throwing error due to permissions issue
- Change from debug to info in patient bulk upload service log
- Add additional logging about patient bulk upload errors
- Removed babel unused dependencies
- Enable patient bulk upload
- Add helper methods for FhirConverterTest
- Add file size limits to patient uploader
- Bump react-redux from 7.2.6 to 8.0.5 in /frontend
- add test performed to db model
- Bump babel-loader from 8.1.0 to 9.1.2 in /frontend
- Don't cancel ongoing test jobs, to prevent loss of TF lock control.
- Johanna/2908 react 18 upgrade
- fix flaky test in AzureStorageQueueTestEventReportingServiceTest
- Clean up error msg for bulk upload
- style override to remove hover state
- 4867 Row errors extend off page boundary (patient bulk upload)
- Fix initial CodeQL scan findings
- Fix patient bulk upload for non-Okta environments
- Copy updates for patient bulk upload
- Make phone number type required for patient bulk upload
- Refactor BaseGraphQlTest into BaseAuthenticatedFullStackTest
CDCgov/prime-simplereport-site
4 pull requests
Created an issue in CDCgov/prime-simplereport that received 2 comments
Use <form>s for form experiences
Throughout the app, we have forms but never use the semantic element for forms: <form>.
This occurs in:
QuestionsForm.tsx
PersonalDetailsForm.tsx
•
2
comments
Opened 16 other issues in 1 repository
CDCgov/prime-simplereport
16
open
- Modify page title for patient bulk upload and add patient form
- Add a role for the file upload inputs
-
Change headers in bulk upload instructions to
<p> - Focus on error message when an invalid test result is uploaded
-
Modify the
aria-labelfor device lookup "Select" button to contain device name - Change title of device code lookup page
- Hide pagination when no test results upload history
-
Modify the
aria-labels for pending organizations to contain the pending org's name - Fix aria-label for tooltips on org sign up flow's organization information page
-
Add
aria-selectedto default dropdown selections on the Dashboard -
Add aria-hidden to <a> generated by
<CSVLink>component - Improve contrast on deactivated user for Manage Users page
- Add form validation for support admin device forms
-
Remove extra
<h1>on Patient Self Registration Terms of service page -
Remove extra
<h1>on Personal Details Form - Remove extra " | SimpleReport" text in <title> of sign up pages