Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRO-438: Update testing page with React Testing Lib #3049

Merged
merged 15 commits into from May 17, 2022
Merged

Conversation

alexandrumorariu
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Changed the unit test library displayed in the documentation from Enzyme to React Testing Library.

Resolution

Additional Considerations

Links

WRO-438

Comments

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #3049 (49589f3) into develop (e22b941) will increase coverage by 0.01%.
The diff coverage is 81.81%.

❗ Current head 49589f3 differs from pull request most recent head 315920a. Consider uploading reports for the commit 315920a to get more accurate results

@@             Coverage Diff             @@
##           develop    #3049      +/-   ##
===========================================
+ Coverage    48.15%   48.16%   +0.01%     
===========================================
  Files          171      171              
  Lines         9684     9688       +4     
  Branches      2595     2598       +3     
===========================================
+ Hits          4663     4666       +3     
- Misses        3941     3942       +1     
  Partials      1080     1080              
Impacted Files Coverage Δ
packages/ui/Marquee/MarqueeDecorator.js 69.46% <80.00%> (-0.03%) ⬇️
packages/spotlight/src/container.js 85.20% <83.33%> (-0.26%) ⬇️
packages/ui/Touchable/Flick.js 45.09% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22b941...315920a. Read the comment docs.

alexandrumorariu and others added 5 commits April 20, 2022 16:49
Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/testing-components/test-driven-development/index.md Outdated Show resolved Hide resolved
docs/testing-components/test-driven-development/index.md Outdated Show resolved Hide resolved
docs/testing-components/test-driven-development/index.md Outdated Show resolved Hide resolved
docs/testing-components/test-driven-development/index.md Outdated Show resolved Hide resolved
docs/testing-components/unit-testing/index.md Outdated Show resolved Hide resolved
docs/testing-components/unit-testing/index.md Show resolved Hide resolved
docs/testing-components/unit-testing/index.md Outdated Show resolved Hide resolved
docs/testing-components/unit-testing/index.md Outdated Show resolved Hide resolved
docs/testing-components/unit-testing/index.md Outdated Show resolved Hide resolved
@MikyungKim MikyungKim changed the title WRO-438: Update testing page with React Testing Lib. WRO-438: Update testing page with React Testing Lib May 2, 2022
alexandrumorariu and others added 5 commits May 2, 2022 10:42
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
alexandrumorariu and others added 3 commits May 12, 2022 10:44
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com>
@seunghoh seunghoh merged commit 69ec561 into develop May 17, 2022
@seunghoh seunghoh deleted the feature/WRO-438 branch May 17, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants