New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRO-745: Clean up Spotlight document #3069
Conversation
Enact-DCO-1.0-Signed-off-by: Jeonghee Ahn (jeonghee27.ahn@lge.com)
Codecov Report
@@ Coverage Diff @@
## develop #3069 +/- ##
===========================================
+ Coverage 48.08% 48.51% +0.43%
===========================================
Files 171 171
Lines 9719 9860 +141
Branches 2609 2686 +77
===========================================
+ Hits 4673 4784 +111
- Misses 3959 3966 +7
- Partials 1087 1110 +23
Continue to review full report at Codecov.
|
packages/spotlight/SpotlightContainerDecorator/SpotlightContainerDecorator.js
Show resolved
Hide resolved
packages/spotlight/SpotlightContainerDecorator/SpotlightContainerDecorator.js
Outdated
Show resolved
Hide resolved
Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/spotlight/SpotlightContainerDecorator/SpotlightContainerDecorator.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:lgtm:
Checklist
Issue Resolved / Feature Added
There is duplicated api description on
Spotlight
/index.md files.Resolution
SpotlightContainerDecorator.js
(There was nothing to merge in theSpottable
docs.)Additional Considerations
restrict
is not an officially providedconfig
, but it is used for initial setting in many places. (even in the Spotlight example)So I thought
restrict
should be added to theSpotlightContainerDecorator
docsLinks
WRO-745
Comments
Enact-DCO-1.0-Signed-off-by: Jeonghee Ahn (jeonghee27.ahn@lge.com)