Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRO-3893: Fixed React 18 Suspense sample content is not loading inside all-samples app #171

Merged
merged 8 commits into from May 18, 2022
Merged

WRO-3893: Fixed React 18 Suspense sample content is not loading inside all-samples app #171

merged 8 commits into from May 18, 2022

Conversation

stanca-pop-lgp
Copy link
Contributor

Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Refactored React 18 Suspense sample content to load inside all-samples app. Replaced Panels with TabLayout. Removed unused classNames from React18 sampler file App.js.

Resolution

Additional Considerations

Links

WRO-3893

Comments

@stanca-pop-lgp
Copy link
Contributor Author

Travis build fails with the following error:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

@daniel-stoian-lgp
Copy link
Contributor

Please fix all lint warnings
image

adrian-cocoara-lgp
adrian-cocoara-lgp approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daniel-stoian-lgp
daniel-stoian-lgp approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-stoian-lgp daniel-stoian-lgp merged commit e26e4d2 into develop May 18, 2022
@daniel-stoian-lgp daniel-stoian-lgp deleted the feature/WRO-3893 branch May 18, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-stoian-lgp daniel-stoian-lgp daniel-stoian-lgp approved these changes

@adrian-cocoara-lgp adrian-cocoara-lgp adrian-cocoara-lgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stanca-pop-lgp @daniel-stoian-lgp @adrian-cocoara-lgp