Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(sgx): reburnish the SGX GDB documentation #1937

Merged
merged 2 commits into from Jun 3, 2022
Merged

docs(sgx): reburnish the SGX GDB documentation #1937

merged 2 commits into from Jun 3, 2022

Conversation

jarkkojs
Copy link
Contributor

@jarkkojs jarkkojs commented Jun 1, 2022 •
edited

Link: #1938
Closes: #1930

@github-actions github-actions bot added the intel sgx Issues related to Intel SGX label Jun 1, 2022
@enarxbot enarxbot enabled auto-merge (rebase) June 1, 2022 01:46
bstrie
bstrie reviewed Jun 1, 2022
View reviewed changes
README-DEBUG.md Show resolved Hide resolved
@platten
Copy link
Contributor

platten commented Jun 1, 2022

@jarkkojs also please rebase.

@jarkkojs
fix(sgx): symbol-file-commands
185f35d 
`symbol-file` is not cumulative. Thus, `add-symbol-file` must
be used for the 2nd command.

Signed-off-by: Jarkko Sakkinen <jarkko@profian.com>
@jarkkojs
Copy link
Contributor Author

jarkkojs commented Jun 2, 2022

@jarkkojs also please rebase.

done

@jarkkojs jarkkojs requested a review from bstrie June 2, 2022 04:29
bstrie
bstrie reviewed Jun 2, 2022
View reviewed changes
README-DEBUG.md Outdated Show resolved Hide resolved
@jarkkojs
docs(sgx): reburnish the SGX GDB section in README-DEBUG.md
6515fa4 
After this, SEV-SNP section is remaining.

Link: #1938
Closes: #1930
Signed-off-by: Jarkko Sakkinen <jarkko@profian.com>
@jarkkojs jarkkojs requested a review from bstrie June 3, 2022 05:07
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1937 (6515fa4) into main (a51058e) will increase coverage by 6.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
+ Coverage   55.40%   61.76%   +6.35%     
==========================================
  Files         150      150              
  Lines       10076    10092      +16     
==========================================
+ Hits         5583     6233     +650     
+ Misses       4493     3859     -634
Impacted Files Coverage Δ
src/backend/sgx/mod.rs 56.41% <0.00%> (+15.38%) ⬆️
src/backend/sgx/data.rs 88.63% <0.00%> (+20.45%) ⬆️
src/backend/sgx/ioctls.rs 66.29% <0.00%> (+66.29%) ⬆️
src/backend/sgx/attestation.rs 72.03% <0.00%> (+72.03%) ⬆️
src/backend/sgx/thread.rs 88.21% <0.00%> (+88.21%) ⬆️
src/backend/sgx/builder.rs 90.59% <0.00%> (+90.59%) ⬆️
src/backend/sgx/config.rs 96.72% <0.00%> (+96.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51058e...6515fa4. Read the comment docs.

@enarxbot enarxbot merged commit eb453e4 into enarx:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstrie bstrie bstrie approved these changes

@npmccallum npmccallum Awaiting requested review from npmccallum

@haraldh haraldh Awaiting requested review from haraldh

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

Assignees
No one assigned
Labels
intel sgx Issues related to Intel SGX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix GDB related issues in README-DEBUG.MD
4 participants
@jarkkojs @platten @bstrie @enarxbot