Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use spin crate instead of spinning #2410

Merged
merged 1 commit into from Dec 20, 2022
Merged

Conversation

haraldh
Copy link
Member

@haraldh haraldh commented Dec 20, 2022

spinning showed some instabilities while implementing threads on in the VM.

Signed-off-by: Harald Hoyer harald@profian.com

@haraldh haraldh requested a review from a team as a code owner December 20, 2022 11:37
@haraldh haraldh requested a review from dpal December 20, 2022 11:37
@enarxbot enarxbot enabled auto-merge (rebase) December 20, 2022 11:37
@haraldh haraldh force-pushed the fix/spinning branch 3 times, most recently from 8af832c to 4d6ae50 Compare December 20, 2022 11:43
`spinning` showed some instabilities while implementing threads on in
the VM.

Signed-off-by: Harald Hoyer <harald@profian.com>
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #2410 (ff9b9a6) into main (ccf8424) will increase coverage by 8.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2410      +/-   ##
==========================================
+ Coverage   51.47%   59.53%   +8.05%     
==========================================
  Files         169      201      +32     
  Lines        8569    12799    +4230     
==========================================
+ Hits         4411     7620    +3209     
- Misses       4158     5179    +1021     
Impacted Files Coverage Δ
crates/shim-kvm/src/allocator.rs 0.00% <0.00%> (ø)
crates/shim-kvm/src/debug.rs 0.00% <ø> (ø)
crates/shim-kvm/src/exec.rs 0.00% <0.00%> (ø)
crates/shim-kvm/src/gdt.rs 0.00% <ø> (ø)
crates/shim-kvm/src/hostcall.rs 0.00% <ø> (ø)
crates/shim-kvm/src/interrupts.rs 0.00% <ø> (ø)
crates/shim-kvm/src/paging.rs 0.00% <0.00%> (ø)
crates/shim-kvm/src/snp/ghcb.rs 31.21% <ø> (ø)
crates/shim-kvm/src/snp/secrets_page.rs 45.83% <ø> (ø)
crates/shim-kvm/src/spin.rs 0.00% <0.00%> (ø)
... and 108 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@enarxbot enarxbot merged commit 0f04907 into enarx:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants