Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom CSS techs #60

Merged
merged 1 commit into from Sep 23, 2016

Conversation

Projects
None yet
2 participants
@tadatuta
Copy link
Member

commented Sep 21, 2016

No description provided.

@blond
Copy link
Member

left a comment

Не хватает явного переопределения опций про то, откуда взять файлы и куда записать результат.

Смотри пример:

var templateEngineOpts = _.assign({}, templateEngine.templateOptions, {
target: '?.browser.template.js',
filesTarget: '?.template.files'
});

Т.к. раньше использовалась конкретная технология это было не обязательно.

Разные технологии могут иметь разные дефолтные значения.

@tadatuta tadatuta force-pushed the custom-css-techs branch from 40496ad to 05493d1 Sep 23, 2016

@tadatuta

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2016

🆙

@blond
Copy link
Member

left a comment

остались небольшие правки

@@ -42,17 +42,19 @@
"enb": ">= 0.13.0 < 2.0.0",
"enb-bh": "1.2.0",
"enb-magic-factory": ">= 0.3.0 < 1.0.0",
"enb-postcss": "^1.1.0",

This comment has been minimized.

Copy link
@blond

blond Sep 23, 2016

Member

точная версия

"eslint": "2.5.3",
"eslint-config-pedant": "0.1.1",
"jscs": "1.11.0"
"jscs": "1.11.0",
"postcss-import": "^8.1.2"

This comment has been minimized.

Copy link
@blond

blond Sep 23, 2016

Member

точная версия

@@ -207,7 +211,7 @@ exports.configure = function (config, options) {
}

// CSS
nodeConfig.addTech(css);
nodeConfig.addTech([cssEngine.tech, _.assign({}, cssEngine.options, { target: '?.css' })]);

This comment has been minimized.

Copy link
@blond

blond Sep 23, 2016

Member

filesTarget: '?.files' тоже надо закрепить. Если кто-то передаст другое значение, то сборка сломается.

@tadatuta tadatuta force-pushed the custom-css-techs branch from 05493d1 to d254444 Sep 23, 2016

@blond

blond approved these changes Sep 23, 2016

@blond blond merged commit a1498e7 into master Sep 23, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@blond blond deleted the custom-css-techs branch Sep 23, 2016

@blond blond removed the in progress label Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.