Skip to content

Commit

Permalink
Update c# version and fix OpenAPi options issue
Browse files Browse the repository at this point in the history
  • Loading branch information
farajfarook committed Nov 23, 2019
1 parent d72abb9 commit 47c9034
Show file tree
Hide file tree
Showing 19 changed files with 26 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
@@ -1,6 +1,6 @@
env:
global:
- PACKAGE_VERSION="3.0.0-rc6"
- PACKAGE_VERSION="3.0.0-rc7"
- PACKAGE_ICON="https://www.enbiso.com/logo.svg"
- PACKAGE_PROJECT="https://nlib.enbiso.com"
- PACKAGE_REPO="https://github.com/enbiso/Enbiso.NLib"
Expand Down
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions Enbiso.NLib.Cqrs/Enbiso.NLib.Cqrs.csproj
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
Expand Up @@ -22,6 +22,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>

</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions Enbiso.NLib.Domain.Events/Enbiso.NLib.Domain.Events.csproj
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions Enbiso.NLib.Domain/Enbiso.NLib.Domain.csproj
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

</Project>
Expand Up @@ -19,6 +19,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.0.*" />
Expand Down
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="3.0.*" />
Expand Down
Expand Up @@ -21,7 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>

<LangVersion>8</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Azure.ServiceBus" Version="4.1.*" />
Expand Down
1 change: 1 addition & 0 deletions Enbiso.NLib.EventBus/Enbiso.NLib.EventBus.csproj
Expand Up @@ -22,6 +22,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
Expand Up @@ -18,6 +18,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="3.0.*" />
Expand Down
Expand Up @@ -19,6 +19,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions Enbiso.NLib.EventLogger/Enbiso.NLib.EventLogger.csproj
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Text.Json" Version="4.6.*" />
Expand Down
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
5 changes: 3 additions & 2 deletions Enbiso.NLib.GlobalExceptions/GlobalExceptionHandler.cs
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.Threading.Tasks;

namespace Enbiso.NLib.GlobalExceptions
Expand All @@ -8,7 +9,7 @@ namespace Enbiso.NLib.GlobalExceptions
/// </summary>
public interface IGlobalExceptionHandler
{
Type[] ValidTypes { get; }
IEnumerable<Type> ValidTypes { get; }

Task<GlobalExceptionResponse> HandleException(Exception exception);
}
Expand All @@ -20,7 +21,7 @@ public interface IGlobalExceptionHandler
public abstract class GlobalExceptionHandler<TException> : IGlobalExceptionHandler
where TException : Exception
{
public Type[] ValidTypes => new [] { typeof(TException) };
public IEnumerable<Type> ValidTypes => new [] { typeof(TException) };
protected abstract Task<GlobalExceptionResponse> Handle(TException ex);

public Task<GlobalExceptionResponse> HandleException(Exception exception)
Expand Down
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="3.0.*" />
Expand Down
1 change: 1 addition & 0 deletions Enbiso.NLib.Idempotency/Enbiso.NLib.Idempotency.csproj
Expand Up @@ -21,6 +21,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.0.*" />
Expand Down
1 change: 1 addition & 0 deletions Enbiso.NLib.OpenApi/Enbiso.NLib.OpenApi.csproj
Expand Up @@ -22,6 +22,7 @@
<PackageIconUrl>$(PACKAGE_ICON)</PackageIconUrl>
<PackageProjectUrl>$(PACKAGE_PROJECT)</PackageProjectUrl>
<RepositoryUrl>$(PACKAGE_REPO)</RepositoryUrl>
<LangVersion>8</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
7 changes: 6 additions & 1 deletion Enbiso.NLib.OpenApi/ServiceExtensions.cs
Expand Up @@ -19,8 +19,13 @@ public static class ServiceExtensions
/// <param name="optBuilder"></param>
public static void AddOpenApi(this IServiceCollection services, Action<OpenApiOptions> optBuilder)
{
services.AddOptions();

optBuilder ??= options => {};
services.Configure(optBuilder);

var opts = new OpenApiOptions();
optBuilder?.Invoke(opts);
optBuilder.Invoke(opts);

services.AddSwaggerGen(c =>
{
Expand Down

0 comments on commit 47c9034

Please sign in to comment.