From b0f895fc9453af9674a15daff28a1c2b8e3b7cf1 Mon Sep 17 00:00:00 2001 From: Bot Date: Fri, 1 Jan 2021 23:56:56 +0100 Subject: [PATCH 1/6] various multiplayer mode bug fixes --- server/rooms.js | 7 ++-- src/App.vue | 3 +- src/components/NavBar.vue | 4 +-- src/components/PlayersList.vue | 17 ++++++---- src/components/RoomPanel.vue | 62 +++++++++++++++------------------- src/main.js | 4 +-- src/store/modules/room.js | 9 +++-- src/views/Run.vue | 6 ++++ src/views/Start.vue | 6 ++-- 9 files changed, 66 insertions(+), 52 deletions(-) diff --git a/server/rooms.js b/server/rooms.js index b50c7784c..bcd649570 100644 --- a/server/rooms.js +++ b/server/rooms.js @@ -111,10 +111,15 @@ module.exports = (http) => { }); socket.on('start', () => { + rooms[roomName].playersCompleted = 0; io.in(roomName).emit('reset'); socket.to(roomName).emit('start'); }); + socket.on('requestNewGame', () => { + socket.to(roomName).emit('requestNewGame'); + }); + socket.on('completed', () => { console.log(`player "${rooms[roomName].players[socket.id].name} completed`); @@ -143,8 +148,6 @@ module.exports = (http) => { }); socket.on('reset', () => { - rooms[roomName].playersCompleted = 0; - if (rooms[roomName].players[socket.id].owner) { console.warn(`room "${roomName}" reset`); io.in(roomName).emit('reset'); diff --git a/src/App.vue b/src/App.vue index b288f5a69..1939ec2a9 100644 --- a/src/App.vue +++ b/src/App.vue @@ -34,7 +34,8 @@ export default { isThin() { console.log('UPDATE'); const { path } = this.$route; - return path === '/run' || (this.innerWidth < 1300 && !this.room.connected && path !== '/'); + // newGameRequest exception because of webkit bug with position: fixed and transfrom http://code.google.com/p/chromium/issues/detail?id=20574 + return !this.room.newGameRequest && (path === '/run' || (this.innerWidth < 1300 && !this.room.connected && path !== '/')); }, }, created() { diff --git a/src/components/NavBar.vue b/src/components/NavBar.vue index 087c34139..36942cb09 100644 --- a/src/components/NavBar.vue +++ b/src/components/NavBar.vue @@ -7,7 +7,7 @@
-

+

{{ roomInfoMsg }}

@@ -117,7 +117,7 @@ -
+

Room owner wants to start a new game.

If you want to stay on current page {{ $route.path === '/results' ? 'and continue reading the results' : '' }} you have to leave the room. You can always join again later.

@@ -156,7 +156,6 @@ export default { origin: window.location.origin, popUp: false, hidePopUp: false, - requestNewGame: false, }; }, computed: { @@ -203,11 +202,6 @@ export default { console.error('PLAYER NAME TAKEN'); this.roomInfoMsg = `Nick "${this.playerName}" is already taken.`; }, - reset() { - if (this.$route.path === '/results' || this.$route.path === '/run') { - this.requestNewGame = true; - } - }, }, mounted() { if (this.$route.params.roomName) { @@ -281,7 +275,7 @@ export default { this.roomInfoMsg = ''; }, acceptNewGame() { - this.requestNewGame = false; + this.$store.commit('SET_ROOM_PROPERTY', ['newGameRequest', false]); this.$router.push('/'); }, }, @@ -312,33 +306,33 @@ input .popUp + display: flex + align-items: center + justify-content: space-around + position: fixed + top: 0 + bottom: 0 + left: 0 + right: 0 + background-color: rgba($navy-grey, .7) + transition: opacity 2s ease-in-out + z-index: 10 + user-select: none + pointer-events: all + + &.hide-popUp + opacity: 0 + + .wrapper display: flex align-items: center - justify-content: space-around - position: fixed - top: 0 - bottom: 0 - left: 0 - right: 0 - background-color: rgba($navy-grey, .7) - transition: opacity 2s ease-in-out - z-index: 10 - user-select: none - pointer-events: all - - &.hide-popUp - opacity: 0 - - .wrapper - display: flex - align-items: center - flex-direction: column - flex-wrap: wrap - text-align: center - width: 50vw - - h2 - font-size: 2.5rem + flex-direction: column + flex-wrap: wrap + text-align: center + width: 50vw + + h2 + font-size: 2.5rem .roomNotConnected diff --git a/src/main.js b/src/main.js index 00ea4a3b4..964b9ec4f 100644 --- a/src/main.js +++ b/src/main.js @@ -6,7 +6,7 @@ import { FontAwesomeIcon, FontAwesomeLayers } from '@fortawesome/vue-fontawesome // import only used icons to reduce bundle size import { - faUsers, faPlay, faInfo, faFileCode, faShareAlt, faTimes, faLink, faHeart, faServer, faUser, faSignOutAlt, faCopy, faUserCog, faCheck, faHourglassEnd, faSignal, faSlash, faCompressAlt, faExpandAlt, + faUsers, faPlay, faHome, faInfo, faFileCode, faShareAlt, faTimes, faLink, faHeart, faServer, faUser, faSignOutAlt, faCopy, faUserCog, faCheck, faHourglassEnd, faSignal, faSlash, faCompressAlt, faExpandAlt, } from '@fortawesome/free-solid-svg-icons'; import { @@ -17,7 +17,7 @@ import App from './App.vue'; import router from './router'; import store from './store'; -library.add(faUsers, faPlay, faInfo, faFileCode, faShareAlt, faTimes, faLink, faFacebookF, faFacebookMessenger, faTwitter, faHeart, faServer, faUser, faSignOutAlt, faCopy, faUserCog, faCheck, faHourglassEnd, faSignal, faSlash, faCompressAlt, faExpandAlt); +library.add(faUsers, faPlay, faHome, faInfo, faFileCode, faShareAlt, faTimes, faLink, faFacebookF, faFacebookMessenger, faTwitter, faHeart, faServer, faUser, faSignOutAlt, faCopy, faUserCog, faCheck, faHourglassEnd, faSignal, faSlash, faCompressAlt, faExpandAlt); Vue.component('fa', FontAwesomeIcon); Vue.component('faStack', FontAwesomeLayers); diff --git a/src/store/modules/room.js b/src/store/modules/room.js index ae5861568..a1ff17260 100644 --- a/src/store/modules/room.js +++ b/src/store/modules/room.js @@ -51,7 +51,7 @@ const actions = { commit('SET_ROOM_PROPERTY', ['players', playersObject]); if (roomState.languageIndex) { - commit('SET_LANGUAGE', rootState.other.languagesList[roomState.languageIndex]); + commit('SET_LANGUAGE', rootState.misc.languagesList[roomState.languageIndex]); } else { commit('SET_LANGUAGE', { index: null, @@ -84,7 +84,7 @@ const actions = { commit('SET_OPTION', option); }, socket_languageChange({ commit, rootState }, languageIndex) { - commit('SET_LANGUAGE', rootState.other.languagesList[languageIndex]); + commit('SET_LANGUAGE', rootState.misc.languagesList[languageIndex]); }, socket_fileIndex({ dispatch }, fileIndex) { dispatch('generateCodeInfo', fileIndex); @@ -100,6 +100,11 @@ const actions = { commit('RESET_PLAYER', playerName); }); }, + socket_requestNewGame({ commit, state }) { + if (!state.room.players[state.room.myName].inLobby) { + commit('SET_ROOM_PROPERTY', ['newGameRequest', true]); + } + }, }; const mutations = { diff --git a/src/views/Run.vue b/src/views/Run.vue index 102849fe8..bf6a98df0 100644 --- a/src/views/Run.vue +++ b/src/views/Run.vue @@ -106,6 +106,8 @@ export default { } }, beforeRouteUpdate(to, from, next) { + console.red('routeUpdate'); + if (to.path === '/results') { setTimeout(() => { this.$refs.results.scrollIntoView({ @@ -122,6 +124,10 @@ export default { if (this.intervalId) { window.clearInterval(this.intervalId); } + if (this.room.connected) { + // reset players locally but let them finish and view results until admin clicks start again + this.$store.dispatch('socket_reset'); + } }, methods: { reset() { diff --git a/src/views/Start.vue b/src/views/Start.vue index 29f41ea70..55cbdddf7 100644 --- a/src/views/Start.vue +++ b/src/views/Start.vue @@ -174,8 +174,8 @@ export default { } if (this.room.connected && !this.playersInLobby) { - this.error = 'To start a new game all of the players must be in lobby'; - this.$socket.client.emit('reset'); + this.error = 'To start a new game all players must be in lobby'; + this.$socket.client.emit('requestNewGame'); return; } @@ -276,6 +276,8 @@ export default { width: 150px height: 47px max-width: 250px + &:disabled + cursor: not-allowed .start-btn, .ready-btn background: linear-gradient(to right, $purple, $dark-pink 50%, $navy-grey 50% 100%) From 0f25bbd395c675bf3eccdfbbbbf2198ff5f87dba Mon Sep 17 00:00:00 2001 From: Bot Date: Fri, 1 Jan 2021 23:57:32 +0100 Subject: [PATCH 2/6] remove whitespace in first line --- public/code/Python/UrlParser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/code/Python/UrlParser.py b/public/code/Python/UrlParser.py index 7723f78c2..ceb3153ea 100644 --- a/public/code/Python/UrlParser.py +++ b/public/code/Python/UrlParser.py @@ -1,4 +1,4 @@ - @property +@property def port(self): port = self._hostinfo[1] if port is not None: From 2a860af10c0ee58231b88c869175f65a4ab1984a Mon Sep 17 00:00:00 2001 From: Bot Date: Sat, 2 Jan 2021 01:14:22 +0100 Subject: [PATCH 3/6] stretch random lang btn to fill empty cells --- src/App.vue | 1 - src/components/LanguagesList.vue | 45 ++++++++++++++++++++++++++++++-- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/src/App.vue b/src/App.vue index 1939ec2a9..a39d27b52 100644 --- a/src/App.vue +++ b/src/App.vue @@ -32,7 +32,6 @@ export default { computed: { ...mapGetters(['room', 'trackedContainers', 'smallScreen']), isThin() { - console.log('UPDATE'); const { path } = this.$route; // newGameRequest exception because of webkit bug with position: fixed and transfrom http://code.google.com/p/chromium/issues/detail?id=20574 return !this.room.newGameRequest && (path === '/run' || (this.innerWidth < 1300 && !this.room.connected && path !== '/')); diff --git a/src/components/LanguagesList.vue b/src/components/LanguagesList.vue index 5420069fa..3516ee827 100644 --- a/src/components/LanguagesList.vue +++ b/src/components/LanguagesList.vue @@ -26,8 +26,9 @@ >
-
+

We can't generate accurate results from this round. @@ -490,7 +490,7 @@ export default { }, onUnFocus(_, ev) { if (ev) { - if (DEV) ev.preventDefault(); + if (!DEV) ev.preventDefault(); // dev if (!this.isCompleted && this.popUpText !== 'Try again' && ev) { if (DEV) this.cm.focus(); if (ev.relatedTarget !== null) { @@ -501,7 +501,7 @@ export default { } } else { // eslint-disable-next-line no-lonely-if - if (!DEV) this.popUp(true, 'Resume'); + if (DEV) this.popUp(true, 'Resume'); // dev } } } diff --git a/src/components/LanguagesList.vue b/src/components/LanguagesList.vue index 2b6d6f5cc..bc391b645 100644 --- a/src/components/LanguagesList.vue +++ b/src/components/LanguagesList.vue @@ -6,6 +6,7 @@ type="text" placeholder="Search" class="searchInput" + :disabled="room.connected && !room.admin" maxlength="12" autofocus @keydown.enter.stop="selectFirstFromSearch" @@ -83,7 +84,7 @@ export default { const filtered = this.languagesList .filter((language) => language.name.toLowerCase().includes(search)) .sort((a, b) => (b.name.toLowerCase().startsWith(search) ? 1 : -1)); - return filtered.length === 0 || (this.room.connected && !this.room.admin) ? this.languagesList : filtered; + return filtered.length === 0 ? this.languagesList : filtered; } return [...Array(33)].map(() => ({ name: '...' })); }, diff --git a/src/components/RoomPanel.vue b/src/components/RoomPanel.vue index 2e94bf21b..08acb8182 100644 --- a/src/components/RoomPanel.vue +++ b/src/components/RoomPanel.vue @@ -260,6 +260,7 @@ export default { this.$store.commit('SET_ROOM_PROPERTY', ['connected', false]); this.$store.commit('SET_ROOM_PROPERTY', ['name', '']); this.$store.commit('SET_ROOM_PROPERTY', ['owner', false]); + this.$store.commit('SET_ROOM_PROPERTY', ['newGameRequest', false]); if (action) { this.askForPlayerName = false; this.roomName = ''; From f7199ee66d1afeb268f0090c33f11de81438fe1a Mon Sep 17 00:00:00 2001 From: Bot Date: Sat, 2 Jan 2021 02:04:08 +0100 Subject: [PATCH 6/6] remove debug code --- src/components/CodeEditor.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/CodeEditor.vue b/src/components/CodeEditor.vue index b85f49024..231a01965 100644 --- a/src/components/CodeEditor.vue +++ b/src/components/CodeEditor.vue @@ -490,7 +490,7 @@ export default { }, onUnFocus(_, ev) { if (ev) { - if (!DEV) ev.preventDefault(); // dev + if (DEV) ev.preventDefault(); if (!this.isCompleted && this.popUpText !== 'Try again' && ev) { if (DEV) this.cm.focus(); if (ev.relatedTarget !== null) { @@ -501,7 +501,7 @@ export default { } } else { // eslint-disable-next-line no-lonely-if - if (DEV) this.popUp(true, 'Resume'); // dev + if (!DEV) this.popUp(true, 'Resume'); } } }