This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
python37 type check fix #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2018
d0ugal
approved these changes
Aug 16, 2018
tomchristie
reviewed
Aug 17, 2018
| @@ -88,9 +88,10 @@ def generate_response(self, handler): | |||
| return Response(encoding='application/json', status_code=200, schema=annotation) | |||
|
|
|||
| def coerce_generics(self, annotation): | |||
| origin = getattr(annotation, '__origin__', annotation) | |||
There was a problem hiding this comment.
Can't say it make me happy, but sure.
|
Thanks! |
|
Thank you for accepting my PRs! ) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a finishing of #598 ( python 3.7 issue - #595 )
It fixes type checks which prevented to generate schema responses when running in python 3.7
It also adds
3.7-devto the travis matrix.I ran tests on python 3.6 and 3.7 and they're ok:
========================== 316 passed in 8.79 seconds ==========================.......