Permalink
Browse files

Refactor add_query_param to use URLObject. Refs #112.

  • Loading branch information...
1 parent c8134a6 commit 97c5262e9ca318d0ff62d44a1f2d3ea31120d282 @tomchristie tomchristie committed Jan 11, 2012
Showing with 3 additions and 9 deletions.
  1. +3 −9 djangorestframework/templatetags/add_query_param.py
@@ -1,17 +1,11 @@
from django.template import Library
-from urlparse import urlparse, urlunparse
-from urllib import quote
+from urlobject import URLObject
register = Library()
+
def add_query_param(url, param):
(key, sep, val) = param.partition('=')
- param = '%s=%s' % (key, quote(val))
- (scheme, netloc, path, params, query, fragment) = urlparse(url)
- if query:
- query += "&" + param
- else:
- query = param
- return urlunparse((scheme, netloc, path, params, query, fragment))
+ return unicode(URLObject(url) & (key, val))
register.filter('add_query_param', add_query_param)

0 comments on commit 97c5262

Please sign in to comment.