Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relational fields are missing translation marker for strings. #2231

Closed
m-aciek opened this issue Dec 8, 2014 · 5 comments
Closed

Relational fields are missing translation marker for strings. #2231

m-aciek opened this issue Dec 8, 2014 · 5 comments
Labels
Milestone

Comments

@m-aciek
Copy link

m-aciek commented Dec 8, 2014

The default Django translation isn't applied to 'required' error message on PrimaryKeyRelatedField.

I blame this line. I'm sorry not to requesting a pull with a solution myself, but I'm a bit too new to GitHub.

@tomchristie tomchristie added this to the 3.0.1 Release milestone Dec 8, 2014
@tomchristie tomchristie added the Bug label Dec 8, 2014
@tomchristie tomchristie changed the title 'required' error message not being localized in PrimaryKeyRelatedField class. Relational fields are missing translation marker for strings. Dec 8, 2014
@tomchristie
Copy link
Member

tomchristie commented Dec 8, 2014

Yup, thanks for the report. Clearly missing the _(message) translation markers around those errors and others in relations.py.

@tomchristie
Copy link
Member

tomchristie commented Dec 8, 2014

Once that's resolved you will also want to note #2217 - some changes in error strings from 2.x -> 3.0 so you may need to review any translation files.

@jpadilla
Copy link
Member

jpadilla commented Dec 8, 2014

These seem to be missing translation markers:

@tomchristie
Copy link
Member

tomchristie commented Dec 8, 2014

Agreed, exactly those.

@tomchristie
Copy link
Member

tomchristie commented Dec 8, 2014

@jpadilla Fixing these up now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants