Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.8 alpha support #2425

Closed
tomchristie opened this issue Jan 17, 2015 · 10 comments
Closed

Add 1.8 alpha support #2425

tomchristie opened this issue Jan 17, 2015 · 10 comments

Comments

@tomchristie
Copy link
Member

tomchristie commented Jan 17, 2015

Add 1.8 alpha to the test matrix and resolve any issues.

The current builds against Django master indicate that there are some failures that will need resolving. It's unclear what's causing these. If they're not due to us using private Django API and they're not documented changes then it could also be valid to raise any upgrade issues 1.8 alpha presents as Django tickets.

@xordoquy
Copy link
Collaborator

xordoquy commented Jan 17, 2015

Is there a PR already for this ?

@tomchristie
Copy link
Member Author

tomchristie commented Jan 17, 2015

Nope nothing yet.

@DavidMuller
Copy link

DavidMuller commented Jan 17, 2015

I checked this out a few weeks ago: the majority of the failures against Django master (Failed: Database access not allowed, use the "django_db" mark to enable) have to do with pytest-django's compatibility with Django 1.8.

@pelme recently merged in support for 1.8, but has not released the updates on PyPI yet.

@pelme
Copy link
Contributor

pelme commented Jan 18, 2015

@DavidMuller A new version is released now, so it should now be fixed :)

@tomchristie
Copy link
Member Author

tomchristie commented Jan 19, 2015

Closed thanks to work by @DavidMuller in #2427.

Thanks again!

@tomchristie
Copy link
Member Author

tomchristie commented Jan 19, 2015

Reopening this - hadn't noticed that 1.8-alpha is currently in the "expected failure" column.
Evidently still work to do here.

@tomchristie tomchristie reopened this Jan 19, 2015
@stianjensen
Copy link
Contributor

stianjensen commented Jan 19, 2015

Django-filter are working on an update for 1.8 support:
carltongibson/django-filter#210

@tomchristie
Copy link
Member Author

tomchristie commented Jan 23, 2015

Some issues due to this change in Django behavior which I've raised as an issue... https://code.djangoproject.com/ticket/24208#ticket

@tomchristie
Copy link
Member Author

tomchristie commented Jan 23, 2015

Resolved by #2446.
django-filter is currently not included in our test matrix for 1.8 so we don't yet have support there, but we can add that once they've resolved any issues there.

@xordoquy
Copy link
Collaborator

xordoquy commented Jan 23, 2015

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants