Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewset Docstring Shows in Browsable API Even when Method Return 403 #3216

Closed
cancan101 opened this issue Aug 3, 2015 · 3 comments
Closed
Labels
Milestone

Comments

@cancan101
Copy link
Contributor

cancan101 commented Aug 3, 2015

The docstring for a viewset shows in the HTML browsable API even when the GET method returns 403.

@tomchristie
Copy link
Member

tomchristie commented Aug 4, 2015

Masking that on 401, 403 sounds sensible, yeah.

@tomchristie tomchristie added the Bug label Aug 4, 2015
@tomchristie tomchristie added this to the 3.2.0 Release milestone Aug 5, 2015
@tomchristie
Copy link
Member

tomchristie commented Aug 5, 2015

Okay, now resolved.

I considered adding something similar for the view name, but it wasn't immediately clear to me if that'd be sufficient (eg presumbly we'd still have the breadcrumbs) or neccessarily desirable, but I'd accept an issue on that too, if it came attached with before and after screenshots of the behavior as we'd like to see from it.

@Kos
Copy link

Kos commented May 24, 2016

Blast, this was intentional? I almost reported a bug. I kind of depended on the docstrings as publicly available API documentation. Will need to figure something else out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants