Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm delete modal for browser api and admin #3228

Closed
mcastle opened this issue Aug 6, 2015 · 5 comments
Closed

Confirm delete modal for browser api and admin #3228

mcastle opened this issue Aug 6, 2015 · 5 comments
Labels
Enhancement

Comments

@mcastle
Copy link
Contributor

mcastle commented Aug 6, 2015

Should probably have a confirm modal after user presses Delete button in the browser api and admin.
@tomchristie tomchristie modified the milestone: 3.2.1 Release Aug 7, 2015
@tomchristie tomchristie modified the milestone: 3.2.3 Release Aug 24, 2015
@auvipy
Copy link
Member

auvipy commented Nov 3, 2015

is it on 3.2.3 already?

@tomchristie
Copy link
Member

@auvipy This is an open issue, so no. (Unless I'm being dense)

@awwester
Copy link
Contributor

working on this ticket here https://github.com/awwester/django-rest-framework/tree/ticket_3228

jpadilla added a commit that referenced this issue Dec 1, 2015
@jpadilla
Merge pull request #3662 from awwester/ticket_3228
d2f90fd 
#3228 - add confirm modal for delete
@mcastle
Copy link
Contributor Author

mcastle commented Dec 2, 2015

Fixed by #3662.

@mcastle mcastle closed this as completed Dec 2, 2015
@tomchristie
Copy link
Member

👍 Yup, thanks for closing.

@pyup-bot pyup-bot mentioned this issue Oct 22, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Oct 30, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Feb 26, 2017
Merged
This was referenced Mar 9, 2017
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this issue Jun 7, 2017
Closed
@pyup-bot pyup-bot mentioned this issue Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tomchristie @mcastle @awwester @auvipy