-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Admin and API browser fails for views without a filter_class #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ugh! Yeah that's definitely what I thought might happen with #3560. @mcastle can you confirm this is happening with the just released 3.3.1? Update: Specifically talking about this comment on #3560. |
Yep, this happened with 3.3.1. |
Same for me with 3.3.1, upgraded for #3560 |
Thanks for confirming. So I think what should probably be happening here is that if there's no filter class the filter backend's |
Check if view has a filter_class. If not, skip trying to get and append a filter html element for it.
Uses encode#3597, but without using `Context`.
The JSON browser does work though. It seems crispy forms breaks because it's expecting a filter form even when there is no filter_class set on a given view.
The text was updated successfully, but these errors were encountered: