Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas Generator produces error for views with no pagination class. #4289

Closed
5 of 6 tasks
f1shear opened this issue Jul 20, 2016 · 0 comments
Closed
5 of 6 tasks

Schemas Generator produces error for views with no pagination class. #4289

f1shear opened this issue Jul 20, 2016 · 0 comments
Labels
Milestone

Comments

@f1shear
Copy link

f1shear commented Jul 20, 2016

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

Class TaskList(generics.ListCreateAPIView):
    queryset =  TaskModel.objects.all()
    serializer_class = TaskSerializer
    pagination_class = None


class ApiDocView(APIView):

    def get(self, request, format=None):
        generator = schemas.SchemaGenerator(title='API')
        return Response(generator.get_schema(request=request))

Expected behavior

Schema generator should consider views with pagination_class = None.
This issue is similar to #4265

Actual behavior

Schema generator gives error
File "/path/to/env/local/lib/python2.7/site-packages/rest_framework/schemas.py", line 284, in get_pagination_fields
paginator = view.pagination_class()
TypeError: 'NoneType' object is not callable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants