Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema generator ignores detail_route and list_route overrides of serializer_class #4330

Closed
6 tasks done
Nnonexistent opened this issue Jul 28, 2016 · 0 comments
Closed
6 tasks done
Milestone

Comments

@Nnonexistent
Copy link

Nnonexistent commented Jul 28, 2016

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

class ExampleSerializer(serializers.Serializer):
    a = serializers.CharField(required=True)
    b = serializers.CharField(required=False)

class AnotherSerializer(serializers.Serializer):
    c = serializers.CharField(required=True)
    d = serializers.CharField(required=False)

class ExampleViewSet(ModelViewSet):
    serializer_class = ExampleSerializer

    @detail_route(methods=['post'], serializer_class=AnotherSerializer)
    def custom_action(self, request, pk):
        return super(ExampleSerializer, self).retrieve(self, request)

Expected behavior

Fields c and d from AnotherSerializer in generated schema.

Actual behavior

Fields a and b from ExampleSerializer - serializer of viewset itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants