Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.10 RemovedInDjango20Warning: Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. #4354

Closed
5 of 6 tasks
RevolutionTech opened this issue Aug 3, 2016 · 0 comments

Comments

@RevolutionTech
Copy link

RevolutionTech commented Aug 3, 2016

user.is_authenticated() is used throughout code (I first noticed it in permissions.py), but in Django 1.10 is_authenticated is now a property, rather than a method.

This causes a warning in Django 1.10, but in Django 2.0 this code will cease to work.

The full exception message is Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.

Ref: https://docs.djangoproject.com/en/1.10/releases/1.10/#using-user-is-authenticated-and-user-is-anonymous-as-methods

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

I imagine the easiest way to reproduce this would be to just run DRF's tests and look out for the warnings, or to run tests with -Werror. I reproduced the issue by running a test that calls an API endpoint with APIView as the parent class and with the IsAuthenticated permissions class.

Expected behavior

No warning.

Actual behavior

RemovedInDjango20Warning: Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants