Not calling function with source= anymore

[debnet]

Here the serializer:

class IndividuSerializer(ModelSerializer):
    # ...
    sexe_display = CharField(source='get_sexe_display', label='sexe', read_only=True)

The API doesn't display the choice values from Django models anymore.

{
    "url": "http://localhost:8000/api/dsn/individu/1/",
    "id": 1,
    "metadatas": null,
    "sexe_display": "<bound method curry.<locals>._curried of <Individu: XXX XXX>>",
    "...": "..."
}

In the previous release it worked just fine. ;)

[tomchristie]

I'm not able to replicate this.

For example...

class UserSerializer(serializers.ModelSerializer):
    username = serializers.CharField(source='get_username', read_only=True)

    class Meta:
        model = User
        fields = ('id', 'username', 'email')

Results in this...

Could you try to reduce this to a reproducible test case, or similar?

[guinner]

class IndividuSerializer(ModelSerializer):
    # ...
    sexe_display = CharField(source='get_sexe_display', label='sexe', read_only=True)

The field sexe is defined in django model. And The method get_sexe_display is django's _get_FIELD_display. It's returned <bound method curry.<locals>._curried of <Individu: XXX XXX>>.

_curried(*moreargs, **morekwargs) is defined in django.utils.functional

But In drf 'fields.py' line 62, method is_simple_callable, param.default is always param.empty.
https://github.com/tomchristie/django-rest-framework/blob/master/rest_framework/fields.py#L62

[rpkilby]

I've started a patch which is failing - will have to come back to this later.

The problem with the patch implementation is that it can't determine if _args and *_kwargs are safely callable.

[rpkilby]

For those in need of a quick fix for get_FIELD_display(), you can add a FIELD_display property that simply calls the method.