Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BooleanField should also parse 'on' #4624

Closed
4 of 6 tasks
rsalmaso opened this issue Oct 25, 2016 · 1 comment
Closed
4 of 6 tasks

BooleanField should also parse 'on' #4624

rsalmaso opened this issue Oct 25, 2016 · 1 comment

Comments

@rsalmaso
Copy link
Contributor

rsalmaso commented Oct 25, 2016

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

$(form).serialize() serialize checkbox with no value to "on" or "off"

Expected behavior

Add "on" to TRUE_VALUES and "off" to FALSE_VALUES
(I don't always have the control over html/js to add value to checkboxes).

Actual behavior

Value is ignored

@tomchristie
Copy link
Member

tomchristie commented Nov 1, 2016

I'm a little lukewarm on this, but sure, let's go ahead. Seems a common enough style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants