You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attempt to render a schema with normal schema_view
Expected behavior
Renders schema.
Actual behavior
Raises UnboundLocalError
Investigation
The most direct cause of the error is that there is a Try/Except block at L531 of schemas.py that tries to get a field from the model that doesn't exist. This throws an Exception, but there is a pass in the except block which just allows things to keep going, producing the error when the next line of code attempts to access the uninstantiated variable. (Sorry for the "duh" explanation, but it is odd that there would be a pass there -- perhaps some debugging code that wasn't removed?)
Anyway, the model._meta.get_field(variable) at L532 fails because the variable being checked (which is returned by uritemplate.variables()) is 'id' and there is no field named 'id' in this model; the field being used as the actual id is 'alpha', which is a OneToOneField set as a primary key and parent link.
I'm using AlphaPrivate to maintain some private information with different permissions that would otherwise be part of Alpha -- hence the primary_key=True and parent_link=True in the above. Now I should mention that I'm unsure if I'm misconfiguring things in some way by using the above approach. That's why I haven't supplied a test: it seems just as likely that I am not doing things in the right way as I've found a legit bug.
Happy to expand further if necessary.
The text was updated successfully, but these errors were encountered:
I've hit this too, and at least with my code path, the issue is actually that the field model_field is not initialized; initializing it correctly at line 530 of schemas.py like so resolves the problem:
model_field = None # <== Add this
# Attempt to infer a field description if possible.
try:
model_field = model._meta.get_field(variable)
except:
pass
Checklist
master
branch of Django REST framework.Steps to reproduce
With:
Attempt to render a schema with normal
schema_view
Expected behavior
Renders schema.
Actual behavior
Raises
UnboundLocalError
Investigation
The most direct cause of the error is that there is a Try/Except block at L531 of schemas.py that tries to get a field from the model that doesn't exist. This throws an Exception, but there is a
pass
in the except block which just allows things to keep going, producing the error when the next line of code attempts to access the uninstantiated variable. (Sorry for the "duh" explanation, but it is odd that there would be apass
there -- perhaps some debugging code that wasn't removed?)Anyway, the
model._meta.get_field(variable)
at L532 fails because thevariable
being checked (which is returned byuritemplate.variables()
) is 'id' and there is no field named 'id' in this model; the field being used as the actual id is 'alpha', which is a OneToOneField set as a primary key and parent link.I'm using
AlphaPrivate
to maintain some private information with different permissions that would otherwise be part ofAlpha
-- hence theprimary_key=True
andparent_link=True
in the above. Now I should mention that I'm unsure if I'm misconfiguring things in some way by using the above approach. That's why I haven't supplied a test: it seems just as likely that I am not doing things in the right way as I've found a legit bug.Happy to expand further if necessary.
The text was updated successfully, but these errors were encountered: