I have reduced the issue to the simplest possible case.
I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)
Steps to reproduce
Create a View with a custom ApiSettings with EXCEPTION_HANDLER specified
Trigger an exception and notice that the custom exception handler isn't triggered because the APIView class only ever uses rest_framework.settings.api_settings.
Expected behavior
View uses self.settings since views can override settings objects so easily.
Actual behavior
Uses default handler instead
Extras
The 3.4 series used self.settings.EXCEPTION_HANDLER but 3.5 moved to use get_exception_handler which started using rest_framework.settings.api_settings.
The text was updated successfully, but these errors were encountered:
sigmavirus24
added a commit
to sigmavirus24/django-rest-framework
that referenced
this issue
Apr 6, 2017
Checklist
master
branch of Django REST framework.Steps to reproduce
ApiSettings
withEXCEPTION_HANDLER
specifiedrest_framework.settings.api_settings
.Expected behavior
self.settings
since views can override settings objects so easily.Actual behavior
Extras
The 3.4 series used
self.settings.EXCEPTION_HANDLER
but 3.5 moved to useget_exception_handler
which started usingrest_framework.settings.api_settings
.The text was updated successfully, but these errors were encountered: