Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing file in the 3.7.4 release. #5692

Closed
xordoquy opened this issue Dec 20, 2017 · 9 comments
Closed

Missing file in the 3.7.4 release. #5692

xordoquy opened this issue Dec 20, 2017 · 9 comments
Milestone

Comments

@xordoquy
Copy link
Collaborator

xordoquy commented Dec 20, 2017

static/rest_framework/fonts/glyphicons-halflings-regular.woff2 is missing from the 3.7.4 tarball while being in the repository.
Unfortunately this break some static files pipelines since the file is referenced in some css.

@axnsan12
Copy link
Contributor

axnsan12 commented Dec 20, 2017

recursive-include rest_framework/static *.js *.css *.png *.eot *.svg *.ttf *.woff
this line seems to be the problem.

Why is it not simply * instead of listing all the extensions?

@xordoquy
Copy link
Collaborator Author

xordoquy commented Dec 21, 2017

Probably because at some point there was other -intermediate- files in there.

@axnsan12
Copy link
Contributor

axnsan12 commented Dec 21, 2017

And would it be ok to change it to * now? I think that would be safer in the future to prevent things like this from happening again.

@carltongibson
Copy link
Collaborator

carltongibson commented Dec 21, 2017

Looks like #5695 is related. Maxim: Never touch the packaging. (Grrrr. 🙂)

We have the dist build now:

[testenv:dist]
commands = ./runtests.py --fast {posargs} --no-pkgroot -rw
deps =
django
-rrequirements/requirements-testing.txt
-rrequirements/requirements-optionals.txt

We should be able to add smoke tests at least (i.e. they don't need to be perfect) to catch these kind of regressions.

(Grrrr. 🙂)

@xordoquy
Copy link
Collaborator Author

xordoquy commented Dec 21, 2017

And would it be ok to change it to * now? I think that would be safer in the future to prevent things like this from happening again.

That's a double edged sword. It could also include unwanted temporary files.

@axnsan12
Copy link
Contributor

axnsan12 commented Dec 21, 2017

That's a double edged sword. It could also include unwanted temporary files.

Which would IMO be better than missing important files because it's unlikely to break stuff. recursive-excludeor global-exclude would also be able to fix that just as well as including by extension.

One could also argue that temporary/intermediate files should sit in separate directories in the first place.

@xordoquy
Copy link
Collaborator Author

xordoquy commented Dec 21, 2017

One could also argue that temporary/intermediate files should sit in separate directories in the first place.

I totally agree with that by sometime, when it's generated, it's not as easy. I remember packaging my own pyc files once.

We need to weight all that and take a decision.

@tomchristie
Copy link
Member

tomchristie commented Dec 21, 2017

Keep it simple: We add *.woff2 and roll a new release.

@tomchristie tomchristie added this to the 3.7.5 Release milestone Dec 21, 2017
@tomchristie
Copy link
Member

tomchristie commented Dec 21, 2017

3.7.5 released

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this issue Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants