Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning with markdown #6317

Closed
blueyed opened this issue Nov 13, 2018 · 6 comments
Closed

DeprecationWarning with markdown #6317

blueyed opened this issue Nov 13, 2018 · 6 comments

Comments

@blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 13, 2018

Code:

def md_filter_add_syntax_highlight(md):
md.preprocessors.add('highlight', CodeBlockPreprocessor(), "_begin")
return True

Warning:

DeprecationWarning: Using the add method to register a processor or pattern is deprecated. Use the register method instead.

Relevant commit in markdown: Python-Markdown/markdown@6ee07d2

@tomchristie
Copy link
Member

@tomchristie tomchristie commented Jan 8, 2019

This'd probably be a good one for a contributor to jump onto, right?

waves to the world

@rpkilby
Copy link
Member

@rpkilby rpkilby commented Jan 17, 2019

Note - we added the "good first issue" label a while back, which theoretically helps new users find issues like these?

@mcab
Copy link

@mcab mcab commented Jan 20, 2019

I gave it a shot in PR #6412!

@rpkilby
Copy link
Member

@rpkilby rpkilby commented May 31, 2019

Thanks again @mcab!

@dsspeights
Copy link

@dsspeights dsspeights commented Jun 24, 2019

RE: the Release Notes, is there an ETA on when 3.9.X (5?) will be published with this fix?
Getting ready to start a new proj, curious if it would be better to use 3.9.4 or wait (if it will be shortly) for this fix? Using Django 2.2 and django-cors-headers 3.0.2 (latest) Thanks,

@rpkilby
Copy link
Member

@rpkilby rpkilby commented Jun 24, 2019

Hi @dsspeights. This was resolved in #6722, which will be part of the next release (v3.10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants