New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halt on missing related models. #1572

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@barraponto

barraponto commented May 6, 2014

I once mistyped the app name and felt dumb for wasting time looking for a typo.
BTW, what's with django.db.models.get_model() silently failing?

@carltongibson

This comment has been minimized.

Show comment
Hide comment
@carltongibson

carltongibson May 7, 2014

Collaborator

Hmmm. Not sure about this one.

BTW, what's with django.db.models.get_model() silently failing?

That seems to be exactly the point. Isn't this much better fixed in Django rather than worked around in DRF?

@tomchristie, @xordoquy, anyone else — thoughts?

Collaborator

carltongibson commented May 7, 2014

Hmmm. Not sure about this one.

BTW, what's with django.db.models.get_model() silently failing?

That seems to be exactly the point. Isn't this much better fixed in Django rather than worked around in DRF?

@tomchristie, @xordoquy, anyone else — thoughts?

@xordoquy

This comment has been minimized.

Show comment
Hide comment
@xordoquy

xordoquy May 7, 2014

Collaborator

I need to think a bit about this and what's Django behavior to keep things consistent with it.

Collaborator

xordoquy commented May 7, 2014

I need to think a bit about this and what's Django behavior to keep things consistent with it.

@tomchristie

This comment has been minimized.

Show comment
Hide comment
@tomchristie

tomchristie Aug 18, 2014

Member

We've made the decision to close of all currently open serializer tickets, pending the 3.0 release.

The 3.0 release will involve a major redesign and improvement of the current serializer implementation and should invalidate the large majority of these outstanding tickets.

We will be reviewing the closed tickets prior to the 3.0 launch and try to ensure that we have fully covered any long-standing issues, and adequately dealt with the outstanding problems.

If your issue does not appear to be addressed by the upcoming 3.0 release please do comment on your ticket with the current status, and we can reopen any valid tickets as required. In particular, if your ticket represents a long-standing or fundamental problem please do make sure to follow the mailing list and review any 3.0 pre-release candidates where possible.

Note that you can review the closed tickets with the following searches:

Serializer tickets: https://github.com/tomchristie/django-rest-framework/issues?q=label%3ASerializers
Writable nested serializer tickets: https://github.com/tomchristie/django-rest-framework/issues?q=label%3A%22Writable+nested+serializers%22

Many thanks for your understanding and here's looking forward to a new and improved version, and a cleaner more actionable issue list.

All the best,

Tom

Member

tomchristie commented Aug 18, 2014

We've made the decision to close of all currently open serializer tickets, pending the 3.0 release.

The 3.0 release will involve a major redesign and improvement of the current serializer implementation and should invalidate the large majority of these outstanding tickets.

We will be reviewing the closed tickets prior to the 3.0 launch and try to ensure that we have fully covered any long-standing issues, and adequately dealt with the outstanding problems.

If your issue does not appear to be addressed by the upcoming 3.0 release please do comment on your ticket with the current status, and we can reopen any valid tickets as required. In particular, if your ticket represents a long-standing or fundamental problem please do make sure to follow the mailing list and review any 3.0 pre-release candidates where possible.

Note that you can review the closed tickets with the following searches:

Serializer tickets: https://github.com/tomchristie/django-rest-framework/issues?q=label%3ASerializers
Writable nested serializer tickets: https://github.com/tomchristie/django-rest-framework/issues?q=label%3A%22Writable+nested+serializers%22

Many thanks for your understanding and here's looking forward to a new and improved version, and a cleaner more actionable issue list.

All the best,

Tom

@tomchristie tomchristie added this to the 3.0 pre-release reassessment milestone Aug 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment