New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put body block back in base.html #1803

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ErwinJunge
Copy link

ErwinJunge commented Aug 29, 2014

2.4 broke the login template by removing the body block from base.html

This commit fixes it by putting it back.

@tomchristie

This comment has been minimized.

Copy link
Member

tomchristie commented Aug 29, 2014

When you say "broke the login template" do you mean that it displays an error or something else?

@tomchristie

This comment has been minimized.

Copy link
Member

tomchristie commented Aug 29, 2014

Could we get a more minimal pull request that just changes whatever's at issue - there's a whole stack of changes in there, which I can't really review as they stand.

@carltongibson

This comment has been minimized.

Copy link
Collaborator

carltongibson commented Sep 1, 2014

I'm going to close this in favour of #1810. @ErwinJunge — If there's something here not covered there please comment and we can review.

@ErwinJunge

This comment has been minimized.

Copy link

ErwinJunge commented Sep 1, 2014

I agree, it's the same change. All that was different in my PR is that I added 1 level of indentation to all the lines in between the two body tags. I can see how from a code-review standpoint you'd prefer #1810 though :)

@tomchristie

This comment has been minimized.

Copy link
Member

tomchristie commented Sep 1, 2014

Great, thanks for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment