Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing default style for FileField #2172

Merged
merged 1 commit into from Dec 4, 2014
Merged

Added missing default style for FileField #2172

merged 1 commit into from Dec 4, 2014

Conversation

kchang
Copy link
Contributor

@kchang kchang commented Dec 1, 2014

Cherry picked this commit from the PR I submitted at #2065. This change is needed to enable file input.

@tomchristie tomchristie added this to the 3.0.1 Release milestone Dec 3, 2014
@tomchristie
Copy link
Member

tomchristie commented Dec 3, 2014

Looks right, tho surprised. Is file input currently just not available at all in the 3.0 browsable API?

If you're feeling enthusiastic could you also screenshot before & after and attach to this ticket?

@tomchristie tomchristie added the Bug label Dec 3, 2014
@tomchristie
Copy link
Member

tomchristie commented Dec 3, 2014

Otherwise ready for merge, once we've got the extra confirmation.

@kchang
Copy link
Contributor Author

kchang commented Dec 4, 2014

screen shot 2014-12-03 at 4 21 35 pm
screen shot 2014-12-03 at 4 22 50 pm

@kchang
Copy link
Contributor Author

kchang commented Dec 4, 2014

Yeah. It looks like you patched the templates but forgot to include the FileField information in renderer at this commit: 5f580ca and that commit closed my PR

tomchristie added a commit that referenced this issue Dec 4, 2014
Added missing default style for FileField
@tomchristie tomchristie merged commit e8cbf41 into encode:master Dec 4, 2014
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants