Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up compat code #2200

Merged
merged 7 commits into from Dec 5, 2014
Merged

Clean up compat code #2200

merged 7 commits into from Dec 5, 2014

Conversation

maryokhin
Copy link
Contributor

@maryokhin maryokhin commented Dec 4, 2014

I'm half way done, just wanted to put it up for public review. I'll add line comments on why it works without the compat code in the morning..

@kevin-brown
Copy link
Member

kevin-brown commented Dec 4, 2014

You're going to need to remove (or edit) maryokhin@9621948, as right now it will close the ticket if we merge this.

@maryokhin
Copy link
Contributor Author

maryokhin commented Dec 4, 2014

Yes, I'm rebasing now to clean up all the trash commits.

@xordoquy
Copy link
Collaborator

xordoquy commented Dec 4, 2014

This looks good to me. Is there more thing to add ?

@tomchristie
Copy link
Member

tomchristie commented Dec 4, 2014

Neat. There will be a bunch of merge conflicts against the 3.1 branch but no biggie.

@tomchristie tomchristie added this to the 3.0.1 Release milestone Dec 4, 2014
@maryokhin
Copy link
Contributor Author

maryokhin commented Dec 4, 2014

Most moves of packages in Django and Python are handled by a dynamically loaded module django.utils.six.moves which uses a table-like class which remaps paths and imports the correct module. For some reason this powerful feature has only a 2-line description in the docs, so I had to guess around how to use it. Also, because of lazy loading of the modules in django.utils.six.moves IDEs and static analyzers will complain about it.

@maryokhin
Copy link
Contributor Author

maryokhin commented Dec 4, 2014

Should be good to merge now.

@xordoquy
Copy link
Collaborator

xordoquy commented Dec 4, 2014

six.moves is well documented in the six's documentation.
I'll have a closer look at what Django provides with the six library. This should be straight forward but has bitten me in the past.

tomchristie added a commit that referenced this pull request Dec 5, 2014
@tomchristie tomchristie merged commit 65d6cba into encode:master Dec 5, 2014
@tomchristie
Copy link
Member

tomchristie commented Dec 5, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants