Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if fields on serializer is not a list of strings. #2213

Merged
merged 2 commits into from Dec 5, 2014

Conversation

BrickXu
Copy link
Contributor

@BrickXu BrickXu commented Dec 5, 2014

Refs #2193

serializer.data

exception = result.exception
self.assertEqual(str(exception), "Cannot set both 'fields' and 'exclude'.")
Copy link
Member

@tomchristie tomchristie Dec 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather just see these in test_model_serializer.py, but look good otherwise.

@tomchristie
Copy link
Member

tomchristie commented Dec 5, 2014

Nice work! See my inline comments.

@tomchristie tomchristie added this to the 3.0.1 Release milestone Dec 5, 2014
tomchristie added a commit that referenced this issue Dec 5, 2014
Raise error if `fields` on serializer is not a list of strings.
@tomchristie tomchristie merged commit c611a2c into encode:master Dec 5, 2014
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants