Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializer must have data when calling is_valid #2234

Closed

Conversation

vccabral
Copy link
Contributor

@vccabral vccabral commented Dec 8, 2014

@tomchristie this is the start of addressing this issue:
#2228

@tomchristie
Copy link
Member

tomchristie commented Dec 8, 2014

This is about right, but None is a value that might validly be returned by a parser, so it might be better if we switched the default of _initial_data to empty, but that would require a few other changes.

@@ -149,6 +149,7 @@ def save(self, **kwargs):
return self.instance

def is_valid(self, raise_exception=False):
assert self._initial_data is not None
Copy link
Contributor

@BrickXu BrickXu Dec 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any useful message would be thrown here if data is None ?

Copy link
Contributor Author

@vccabral vccabral Dec 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that. Any ideas? @BrickXu

@tomchristie tomchristie added this to the 3.0.2 Release milestone Dec 11, 2014
@tomchristie
Copy link
Member

tomchristie commented Dec 17, 2014

Closed as per #2228.
Again, thanks for getting this moving! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants