Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with imporing rest_framework.views in apps.py #2678

Merged
merged 1 commit into from Mar 12, 2015
Merged

Fixed problem with imporing rest_framework.views in apps.py #2678

merged 1 commit into from Mar 12, 2015

Conversation

dirkmoors
Copy link
Contributor

@dirkmoors dirkmoors commented Mar 12, 2015

I've experienced a problem while imporing rest_framework.views in apps.py, where I would get the notorious 'django.core.exceptions.AppRegistryNotReady: The translation infrastructure cannot be initialized before the apps registry is ready. Check that you don't make non-lazy gettext calls at import time' error. I've traced it back to DRF's pagination.py, where I noticed you are making use of 'ugettext' instead of 'ugettext_lazy'. Replacing this, seems to have fixed my issue.

@jpadilla jpadilla added the Bug label Mar 12, 2015
@jpadilla jpadilla added this to the 3.1.1 Release milestone Mar 12, 2015
@jpadilla
Copy link
Member

jpadilla commented Mar 12, 2015

@dirkmoors good catch, that's the only place we were using ugettext instead of ugettext_lazy.

@dirkmoors
Copy link
Contributor Author

dirkmoors commented Mar 12, 2015

@jpadilla, yeah I noticed it while upgrading from 3.0.5 to 3.1.0. When is 3.1.1 coming out?

jpadilla added a commit that referenced this issue Mar 12, 2015
Fixed problem with imporing rest_framework.views in apps.py
@jpadilla jpadilla merged commit 36e30c8 into encode:master Mar 12, 2015
1 check passed
@tomchristie
Copy link
Member

tomchristie commented Mar 12, 2015

Will make sure it's early next week, latest.

@dirkmoors
Copy link
Contributor Author

dirkmoors commented Mar 12, 2015

@tomchristie Awesome, thank you!

@dirkmoors dirkmoors deleted the fix/ugettext-in-pagination branch Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants