New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document per-view versioning settings #2732

Merged
merged 1 commit into from Jun 19, 2015

Conversation

Projects
None yet
4 participants
@pquentin

pquentin commented Mar 20, 2015

Document the default_version, allowed_version and version_param class variables. This tripped me up in #2731, thank you @tomchristie! By the way, @tomchristie warned me about an issue with reverse. It works fine here, so I'm not sure what to say about this in the docs.

Anything I can improve to make my commit clearer?

Document per-view versioning settings
That is, document the default_version, allowed_version and version_param
class variables.
@pquentin

This comment has been minimized.

Show comment
Hide comment
@pquentin

pquentin Jun 19, 2015

I know you have a lot of pull requests to handle. Is there anything I could do to make your life easier? Thanks!

pquentin commented Jun 19, 2015

I know you have a lot of pull requests to handle. Is there anything I could do to make your life easier? Thanks!

@xordoquy

This comment has been minimized.

Show comment
Hide comment
@xordoquy

xordoquy Jun 19, 2015

Collaborator

@pquentin nothing more that bringing this back on our radars ! :)

Collaborator

xordoquy commented Jun 19, 2015

@pquentin nothing more that bringing this back on our radars ! :)

xordoquy added a commit that referenced this pull request Jun 19, 2015

Merge pull request #2732 from pquentin/patch-versioning
Document per-view versioning settings

@xordoquy xordoquy merged commit 8c5fc2a into encode:master Jun 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xordoquy

This comment has been minimized.

Show comment
Hide comment
@xordoquy

xordoquy Jun 19, 2015

Collaborator

Thanks for the contribution and sorry for the delay.

Collaborator

xordoquy commented Jun 19, 2015

Thanks for the contribution and sorry for the delay.

@pquentin

This comment has been minimized.

Show comment
Hide comment
@pquentin

pquentin commented Jun 19, 2015

@xordoquy Thanks!

@tomchristie

This comment has been minimized.

Show comment
Hide comment
@tomchristie
Member

tomchristie commented Jun 22, 2015

Thanks again @pquentin, @xordoquy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment