Unsaved File Objects may not have a .url attribute.

[ar45]

I'm unsure how this should behave.
basically accessing the serializer.data with a FileField value of InMemoryUploadedFile raises FileField 'InMemoryUploadedFile' object has no attribute 'url'

This example does not provide any special use case, but I guess this should always provide the same behavior no matter what the setting of 'UPLOADED_FILES_USE_URL': False|True

class FileSerializer(serializers.Serializer):
   file = serializers.FileField()

class MyView(views.APIView):
    def post(request, **kwargs):
        s = FileSerializer(data=request.data)
        if s.is_valid():
            return Response(data=serializer.data)
        return Response(data=serializer.errors)

AttributeError at /api/files
'InMemoryUploadedFile' object has no attribute 'url'

[ar45]

Any explanation?
On Mar 24, 2015 5:07 AM, "Tom Christie" notifications@github.com wrote:

Closed #2759
#2759.

—
Reply to this email directly or view it on GitHub
#2759 (comment)
.

[tomchristie]

Sorry I closed this off as it was just the bare link.

The linked message seems like a reasonable conversation tho -
Could you pull the issue description into the ticket, instead of the bare link, and then we'll reopen and consider it.

Thanks! :)

[ar45]

Done, Thanks.

[tomchristie]

I guess in this case we need to return None.
We've request the field to use URLs, but the item hasn't been saved yet, and isn't yet associated with a cocrete, linkable file upload.
Does that sound like and acceptable behavior as far as you're concerned?

Not that if you were to call s.save() you wouldn't see this issue occuring, but this seems valid all the same.

[tomchristie]

Update the title slightly to be a little more explicit.

[ar45]

Sounds fair.

[kevin-brown]

Looks like this if not value check should be moved to the top of the method instead of being hidden away here.

[tomchristie]

True.

[kevin-brown]

Looks like we have a general bug sitting around, and that's also causing a test failure here.