Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth should reduce #2798

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Conversation

Boomerangz
Copy link
Contributor

Depth should reduce

Depth should reduce
@jpadilla
Copy link
Member

jpadilla commented Apr 9, 2015

@Boomerangz I think we need a bit more here to understand what's going on. What's the wrong current behavior and how does it compare with this. A test case might also be needed as well.

@Boomerangz
Copy link
Contributor Author

Ok. I'm sorry.
Some bug like this was fixed in issue
#2287
It was fixed in 2 lines of code. Depth was reducing on each level of nested serialization.
Now, in one of this lines depth isn't reducing.
My test case is totally similiar to the test case of the issue.
I set meta property depth=1, but when i check result i see full hierarchy of my models serialized

@jpadilla
Copy link
Member

@Boomerangz ah I see now. It seemed it was fixed in 80bacc5 last year but was probably left out during the serializer rewrite.

@jpadilla
Copy link
Member

@tomchristie this looks good to me as is, wanted to check with you if it might have removed for a reason or by accident.

@tomchristie tomchristie added this to the 3.1.2 Release milestone Apr 27, 2015
@tomchristie
Copy link
Member

Yup - surprised we made it this far without it!

tomchristie added a commit that referenced this pull request Apr 27, 2015
Depth should reduce on nested ModelSerializer classes.
@tomchristie tomchristie merged commit 2eb9107 into encode:master Apr 27, 2015
@tomchristie
Copy link
Member

Thanks @Boomerangz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants