Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell DjangoModelPermissions to rely on get_queryset first. #2863

Merged
merged 1 commit into from
Apr 22, 2015

Conversation

ticosax
Copy link
Contributor

@ticosax ticosax commented Apr 22, 2015

No description provided.

@carltongibson
Copy link
Collaborator

@ticosax Thanks for the pull requests. With this and #2862 can you link to an issue or provide some description to make them easier to assess. (Reading the code is great but some context does help) — Thanks!

@ticosax
Copy link
Contributor Author

ticosax commented Apr 22, 2015

@carltongibson sure.
Views allow to override the behavior of .queryset with get_queryset(). This pull request make sure that DjangoModelPermissions follows the same logic, get the queryset first from get_queryset().

@xordoquy
Copy link
Collaborator

Looks good to me.

@carltongibson
Copy link
Collaborator

Me too.

carltongibson pushed a commit that referenced this pull request Apr 22, 2015
Tell DjangoModelPermissions to rely on get_queryset first.
@carltongibson carltongibson merged commit fe7cd84 into encode:master Apr 22, 2015
@ticosax ticosax deleted the rely-on-get_queryset branch April 22, 2015 09:10
@xordoquy xordoquy added this to the 3.1.2 Release milestone Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants