Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin style #2926

Merged
merged 18 commits into from Jul 30, 2015
Merged

Admin style #2926

merged 18 commits into from Jul 30, 2015

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented May 12, 2015

Refs #1904.

Very much a work-in-progress right now, but may as well make it visible as we go.

image

image

Going with a simple template-only based approach at the moment, that should render fine with existing APIs.

Considering also having a more fully featured third-party admin pacakge that does more opinionated things such as built-in Core API hypermedia support, and proper browser behavior on eg failed validation, which this version will need to handle in a more basic way. (Last part of that actually not as much of an issue as I'd thought)

TODO:

  • Errors need to correctly respond in modals.
  • Links in list view (prob as a control, rather than hyperlinking a field), also have a clean list fields API.
  • Pagination control currently showing even for a single page.
  • Hyperlinks. (Render as URL in JSON, but as text or other value in admin)
  • [ ] Resolve modal flash. Passing on this for now.

For 3.3.0:

  • Clean up detail vs list pages and templates (extend base)
  • Documentation on overriding.
  • Don't always just include the format in outgoing URLs - only do so on defined links in browsable API.
  • Actions and naming of buttons etc (Inc ensuring internationalized), also clean modal overriding.
  • Messages on edit operations.
  • Strip 'format' for the main HTML representation.
  • Form modals to only include the name part of hyperlinks in select elements.
  • SlugRelatedField should hyperlink.
  • Update heroku example
  • Filters in HTML.
  • Document the HTML form API. (Possibly with eg nesting and/or list support)

@tomchristie tomchristie added this to the 3.2.0 Release milestone May 12, 2015
@tomchristie
Copy link
Member Author

@tomchristie tomchristie commented Jul 30, 2015

Going to pull this in now.
Think it's about time we wrap this up as a 3.2 release, with refinements to follow in 3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant