Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecimalField accepts 2E+2 as 200 and validates decimal place correctly. #2948

Merged
merged 2 commits into from May 29, 2015

Conversation

bimusiek
Copy link
Contributor

@bimusiek bimusiek commented May 18, 2015

Fixes #2947

No idea why Travis failed, but I run all tests and all passed.

@tomchristie
Copy link
Member

tomchristie commented May 18, 2015

Here's the failure... https://travis-ci.org/tomchristie/django-rest-framework/jobs/63027829
(Code linting, rather than tests)

@bimusiek
Copy link
Contributor Author

bimusiek commented May 18, 2015

@tomchristie fixed

@xordoquy
Copy link
Collaborator

xordoquy commented May 28, 2015

Annoying, I ran the tests against master and it already works.

@tomchristie
Copy link
Member

tomchristie commented May 29, 2015

Annoying, I ran the tests against master and it already works.

Then I'd suggest a pull request with just the test, and if that's okay then close this one off until/unless we have a failing test to progress against.

@bimusiek
Copy link
Contributor Author

bimusiek commented May 29, 2015

This is weird, I always first write failing test and then fix issue, I am sure when I posted PR it was failing. Will check at monday if it is still the case on master! 👍

@xordoquy
Copy link
Collaborator

xordoquy commented May 29, 2015

I double checked and have no idea why it didn't fail yesterday.

xordoquy added a commit that referenced this pull request May 29, 2015
Added test ensuring DecimalField accepts `2E+2` as 200 and validates decimal place correctly.
@xordoquy xordoquy merged commit ecb3ba5 into encode:master May 29, 2015
@xordoquy xordoquy changed the title Added test ensuring DecimalField accepts 2E+2 as 200 and validates decimal place correctly. DecimalField accepts 2E+2 as 200 and validates decimal place correctly. May 29, 2015
@bimusiek
Copy link
Contributor Author

bimusiek commented May 29, 2015

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_decimal_places in Decimal field are wrong calculated
3 participants