Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support grouped choices. #3225

Merged
merged 8 commits into from Aug 6, 2015
Merged

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Aug 6, 2015

Based on the work in #3108 from @maxpeterson - Thank you!

Closes #1533.

Renders as:

image

maxpeterson and others added 4 commits Jul 3, 2015
This also adds support for mixing single and paired choices:
```
[
    ('poor', 'Poor quality'),
    'medium',
    ('good', 'Good quality'),
]
```
@tomchristie tomchristie added this to the 3.2.0 Release milestone Aug 6, 2015
@tomchristie
Copy link
Member Author

tomchristie commented Aug 6, 2015

@maxpeterson - We could consider something like #3101 as a follow up to this. I chose not to push that in as part of this change as a consequence of it being unclear what behavior we'd want (or even if we do want that behavior). As you mentioned:

I am not certain what the behaviour should be

I think the bottom line might be that we wouldn't accept further complications to the already ad-hoc 'OPTIONS' behavior, however I'd be willing to consider a fresh ticket for it if you were so minded and wanted to discuss further.

tomchristie added a commit that referenced this pull request Aug 6, 2015
@tomchristie tomchristie merged commit 37b4d42 into master Aug 6, 2015
5 checks passed
@tomchristie tomchristie deleted the maxpeterson-grouped-choices-fix branch Aug 6, 2015
@tomchristie tomchristie modified the milestone: 3.2.0 Release Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants