Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML rendering for filters #3315

Merged
merged 9 commits into from Oct 22, 2015
Merged

HTML rendering for filters #3315

merged 9 commits into from Oct 22, 2015

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Aug 21, 2015

Closes #2180.

Filters rendering in the browsable API and admin.

Remaining:

  • Docs.
  • Use translated strings throughout.
  • Render bootstrap forms directly, dropping the crispy forms optional req.
  • Consider search control rendering directly? (But could be a second pass)

This sort of thing...

image


image

@tomchristie tomchristie added this to the 3.3.0 Release milestone Aug 21, 2015
@jpadilla
Copy link
Member

jpadilla commented Aug 21, 2015

@tomchristie looking great, any specific reason for introducing the requirement for crispy forms?

@tomchristie
Copy link
Member Author

tomchristie commented Aug 21, 2015

@jpadilla django-filters won't render nicely with our bootstrap style out-of-the-box.

We'd probably be making it a soft requirement, but there's also a poss of moving DjangoFilterBackend into a third party package, and then including a built-in field filtering class that uses serializers (since they actually have everything we'd need to make this work).

@carltongibson
Copy link
Collaborator

carltongibson commented Sep 1, 2015

there's also a poss of moving DjangoFilterBackend into a third party package

I'd be happy to maintain such a package.

I have a slight niggle about re-creating functionality that already exists; the prejudice is to consolidate effort rather than split it...

@tomchristie
Copy link
Member Author

tomchristie commented Sep 2, 2015

I'd be happy to maintain such a package.

That would be pretty amazing. Ideally I'd like to see us do that with both django-filter and django-guardian so that external deps are only required in external packages.

@carltongibson
Copy link
Collaborator

carltongibson commented Sep 2, 2015

OK. Fine. I'll put something together.

tomchristie added a commit that referenced this issue Oct 22, 2015
First pass at HTML rendering for filters
@tomchristie tomchristie merged commit c53c9ed into master Oct 22, 2015
3 of 4 checks passed
@tomchristie tomchristie deleted the filters branch Oct 22, 2015
@tomchristie tomchristie changed the title First pass at HTML rendering for filters HTML rendering for filters Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants