Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser overriding #3410

Closed
wants to merge 8 commits into from
Closed

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Sep 17, 2015

Method and Content-Type overriding supported via AJAX in the browsable API, rather than dealt with server-side.

Still to do:

  • Admin interface.
  • Address remaining tests.
  • Docs. (Eg update overrides section, X-HTTP-Method-Override)

Closes #1769.
Refs #1174, #1346.

@tomchristie tomchristie added this to the 3.3.0 Release milestone Sep 22, 2015
edmorley pushed a commit to mozilla/treeherder that referenced this issue Nov 13, 2015
The default format used to make test requests is `multipart/form-data`,
unless overridden using `TEST_REQUEST_DEFAULT_FORMAT`:
http://www.django-rest-framework.org/api-guide/testing/#setting-the-default-format

Our API only accepts json and html (see `DEFAULT_RENDERER_CLASSES`), so
we should have always been setting `TEST_REQUEST_DEFAULT_FORMAT` to
`json`, to prevent test failures.

However until recently there was a bug preventing those failures:
encode/django-rest-framework#3214

Which has now been fixed in django-rest-framwork v3.3.x:
encode/django-rest-framework#3410

...so we must fix this before updating to the latest version of d-r-f.
edmorley pushed a commit to mozilla/treeherder that referenced this issue Dec 6, 2015
The default format used to make test requests is `multipart/form-data`,
unless overridden using `TEST_REQUEST_DEFAULT_FORMAT`:
http://www.django-rest-framework.org/api-guide/testing/#setting-the-default-format

Our API only accepts json and html (see `DEFAULT_RENDERER_CLASSES`), so
we should have always been setting `TEST_REQUEST_DEFAULT_FORMAT` to
`json`, to prevent test failures.

However until recently there was a bug preventing those failures:
encode/django-rest-framework#3214

Which has now been fixed in django-rest-framwork v3.3.x:
encode/django-rest-framework#3410

...so we must fix this before updating to the latest version of d-r-f.
edmorley pushed a commit to mozilla/treeherder that referenced this issue Dec 10, 2015
…pe json

The default format used to make test requests is `multipart/form-data`,
unless overridden using `TEST_REQUEST_DEFAULT_FORMAT`:
http://www.django-rest-framework.org/api-guide/testing/#setting-the-default-format

Our API only accepts json and html (see `DEFAULT_RENDERER_CLASSES`), so
we should have always been setting `TEST_REQUEST_DEFAULT_FORMAT` to
`json`, to prevent test failures.

However until recently there was a bug preventing those failures:
encode/django-rest-framework#3214

Which has now been fixed in django-rest-framwork v3.3.x:
encode/django-rest-framework#3410

...so we must fix this before updating to the latest version of d-r-f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants